This repository was archived by the owner on May 12, 2026. It is now read-only.
Fixing an Integer Overflow Issue#121
Merged
Merged
Conversation
lesv
reviewed
Aug 23, 2017
lesv
left a comment
lesv
left a comment
Contributor
There was a problem hiding this comment.
One Q, then I can approve. (I read the comment, but I'm not sure it makes sense.
| assertEquals(tokenString, accessToken.getTokenValue()); | ||
| assertEquals(3600 * 1000L, accessToken.getExpirationTimeMillis().longValue()); | ||
|
|
||
| // Test for large expires_in values (should not overflow). |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
lesv
approved these changes
Aug 28, 2017
Contributor
|
@garrettjonesgoogle I've merged, but can revert if you wish. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the token server responds with a large
expires_invalue to the token refresh request, theServiceAccountCredentialclass runs into an integer overflow. I've added more information at #120.This patch fixes the issue, and provides a test case (test case fails without the fix). This is not a critical issue, as we can expect most token servers to be well behaved. But it would be nice if the credentials were able to handle the case where the server responds with a large
expires_invalue.