Skip to content

feat: Add grpc.xds.resource_type label to xDS client metrics #13358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gcf-merge-on-green merged 1 commit into from
Nov 14, 2025
Merged

feat: Add grpc.xds.resource_type label to xDS client metrics #13358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions spanner/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ const (
metricLabelKeyDirectPathUsed = "directpath_used"
metricLabelKeyGRPCLBPickResult = "grpc.lb.pick_result"
metricLabelKeyGRPCLBDataPlaneTarget = "grpc.lb.rls.data_plane_target"
metricLabelKeyGRPCXDSResourceType = "grpc.xds.resource_type"

// Metric names
metricNameOperationLatencies = "operation_latencies"
Expand Down
1 change: 1 addition & 0 deletions spanner/metrics_monitoring_exporter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ var (
allowedMetricLabels = map[string]bool{
metricLabelKeyGRPCLBPickResult: true,
metricLabelKeyGRPCLBDataPlaneTarget: true,
metricLabelKeyGRPCXDSResourceType: true,
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better maintainability and to avoid potential merge conflicts, it's a good practice to keep the keys in this map literal sorted alphabetically. While the current logical grouping by prefix is reasonable, a consistent alphabetical order is more scalable and less ambiguous as the list of labels grows. Please consider sorting all the entries in the allowedMetricLabels map.

metricLabelKeyClientUID: true,
metricLabelKeyClientName: true,
metricLabelKeyDatabase: true,
Expand Down
Loading