Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion storage/google/cloud/storage/_helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -170,9 +170,12 @@ def update(self, client=None):
``client`` stored on the current object.
"""
client = self._require_client(client)
query_params = {'projection': 'full'}
if self.user_project is not None:
query_params['userProject'] = self.user_project
api_response = client._connection.api_request(
method='PUT', path=self.path, data=self._properties,
query_params={'projection': 'full'}, _target_object=self)
query_params=query_params, _target_object=self)
self._set_properties(api_response)


Expand Down
25 changes: 25 additions & 0 deletions storage/tests/unit/test__helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,31 @@ def test_update(self):
# Make sure changes get reset by patch().
self.assertEqual(derived._changes, set())

def test_update_w_user_project(self):
user_project = 'user-project-123'
connection = _Connection({'foo': 'Foo'})
client = _Client(connection)
derived = self._derivedClass('/path', user_project)()
# Make sure changes is non-empty, so we can observe a change.
BAR = object()
BAZ = object()
derived._properties = {'bar': BAR, 'baz': BAZ}
derived._changes = set(['bar']) # Update sends 'baz' anyway.
derived.update(client=client)
self.assertEqual(derived._properties, {'foo': 'Foo'})
kw = connection._requested
self.assertEqual(len(kw), 1)
self.assertEqual(kw[0]['method'], 'PUT')
self.assertEqual(kw[0]['path'], '/path')
self.assertEqual(
kw[0]['query_params'], {
'projection': 'full',
'userProject': user_project,
})
self.assertEqual(kw[0]['data'], {'bar': BAR, 'baz': BAZ})
# Make sure changes get reset by patch().
self.assertEqual(derived._changes, set())


class Test__scalar_property(unittest.TestCase):

Expand Down