Skip to content
This repository was archived by the owner on Mar 3, 2026. It is now read-only.

fix: move retrieval of package.json to utility function#1941

Merged
shaffeeullah merged 1 commit intogoogleapis:mainfrom
ddelgrosso1:fix-es-build
May 17, 2022
Merged

fix: move retrieval of package.json to utility function#1941
shaffeeullah merged 1 commit intogoogleapis:mainfrom
ddelgrosso1:fix-es-build

Conversation

@ddelgrosso1
Copy link
Contributor

@ddelgrosso1 ddelgrosso1 commented May 17, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1934 🦕

@ddelgrosso1 ddelgrosso1 requested a review from a team as a code owner May 17, 2022 15:53
@ddelgrosso1 ddelgrosso1 requested a review from a team May 17, 2022 15:53
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/nodejs-storage API. labels May 17, 2022
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 17, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/nodejs-storage API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Could not resolve "../package.json" on v5.20.1

2 participants