Provide a from_dict method #152

Activity

1. software-dov commented on Oct 19, 2020

   

   software-dov

   on Oct 19, 2020

   Contributor

   More actions

   Effective duplicate of #151 lumping in under that.
2. software-dov

   closed this as completedon Oct 19, 2020
3. software-dov commented on Oct 19, 2020

   

   software-dov

   on Oct 19, 2020

   Contributor

   More actions

   The message constructor allows just passing in a dict; it already does all the heavy lifting.
   E.g.

   class Squid(proto.message):
       mass_kg = proto.Field(proto.INT32, number=1)
   
   s = Squid({"mass_kg": 20})
4. tswast commented on Oct 19, 2020

   

   tswast

   on Oct 19, 2020

   Author

   More actions

   Does this work with nested message? I recall in the monolith it didn't work the same as the parse from dict method.
5. busunkim96 commented on Oct 19, 2020

   

   busunkim96

   on Oct 19, 2020

   Contributor

   More actions

   @tswast It should work. This is what allows request to be passed as a dict to the service methods. This KMS sample has some nesting: https://github.com/googleapis/python-kms/blob/c349e3efa0b6cf5dbb9043043310ef5fac0fccc5/samples/snippets/update_key_add_rotation.py#L43-L57
6. JustinBeckwith

   assigned

   software-dov

   on Feb 2, 2021
7. Ark-kun commented on Dec 5, 2022

   

   Ark-kun

   on Dec 5, 2022

   Last edited by Ark-kun

   More actions

   The message constructor allows just passing in a dict; it already does all the heavy lifting.

   That constructor is incompatible with message.to_dict and the actual REST API payloads. Meanwhile, .from_json is compatible with .to_json

   This works:

   batch_v1.Job.from_json('{"taskGroups": [{}]}')
   

   This does not work:

   batch_v1.Job({"taskGroups": [{}]})
   

   ---------------------------------------------------------------------------
   ValueError                                Traceback (most recent call last)
   <ipython-input-145-58ddc394e1ed> in <module>
   ----> 1 batch_v1.Job({"taskGroups": [{}]})
   
   /opt/conda/lib/python3.7/site-packages/proto/message.py in __init__(self, mapping, ignore_unknown_fields, **kwargs)
       564 
       565                 raise ValueError(
   --> 566                     "Unknown field for {}: {}".format(self.__class__.__name__, key)
       567                 )
       568 
   
   ValueError: Unknown field for Job: taskGroups