Generic updater: x-release-please-major does not match strings prefixed with 'v' (e.g., 'v<major>') #2421
Description
Generic updater: x-release-please-major does not match strings prefixed with 'v' (e.g., 'v')
Environment details
- Encountered in the release-please-action@v4
release-pleaseversion: 16.12.0
Steps to reproduce
When annotating a file with x-release-please-major like this:
Major: 2 # x-release-please-major
Major with v: v2 # x-release-please-major
The result is the following update:
Major: 3 # x-release-please-major
Major with v: v2 # x-release-please-major
The expected output is:
Major: 3 # x-release-please-major
Major with v: v3 # x-release-please-major
Looking at the generic updater code, this appears to be directly caused by the regex used for single version updates. It looking for a preceding word boundary, which in this case there is none.
I was unable to find documentation on why this is a desired behavior, or is this was fixed in a more recent version.