Skip to content

fix: fixing bug with major version generic updater#2422

Merged
ferrarimarco merged 1 commit intogoogleapis:mainfrom
faradayfan:fix-major-generic-updater
Sep 23, 2025
Merged

fix: fixing bug with major version generic updater#2422
ferrarimarco merged 1 commit intogoogleapis:mainfrom
faradayfan:fix-major-generic-updater

Conversation

@faradayfan
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2421 🦕

@faradayfan faradayfan requested review from a team as code owners November 6, 2024 23:30
@google-cla
Copy link

google-cla bot commented Nov 6, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Nov 6, 2024
@chingor13
Copy link
Contributor

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Thank you for this, but you'll need to sign this before we can consider it

@faradayfan faradayfan force-pushed the fix-major-generic-updater branch from 13950c9 to 7157c10 Compare November 18, 2024 15:58
@lukasnajman-ext44972
Copy link

Hello @faradayfan,
I'm checking in on this pull request. The proposed regex changes would be very helpful for us, as they would allow us to update the version number in our GitHub Action usage samples.
Do you have an estimated timeline for merging these changes?
Thank you for your work on this

@ferrarimarco ferrarimarco force-pushed the fix-major-generic-updater branch from 7157c10 to ec2df05 Compare September 22, 2025 19:49
Copy link
Collaborator

@ferrarimarco ferrarimarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. Can you please fix the linting errors? Thanks.

Update: done

Copy link
Collaborator

@ferrarimarco ferrarimarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And, can you please add a test for this case in test/updaters/generic.ts?

Thanks!

Update: done

@ferrarimarco ferrarimarco force-pushed the fix-major-generic-updater branch from f2ece81 to 387354c Compare September 22, 2025 20:26
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Sep 22, 2025
@ferrarimarco ferrarimarco force-pushed the fix-major-generic-updater branch from 387354c to afcdc66 Compare September 22, 2025 20:27
@ferrarimarco ferrarimarco enabled auto-merge (squash) September 22, 2025 20:29
@ferrarimarco ferrarimarco merged commit 2ec56e7 into googleapis:main Sep 23, 2025
10 of 14 checks passed
zainudinmuji4-commits

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generic updater: x-release-please-major does not match strings prefixed with 'v' (e.g., 'v<major>')

5 participants