Skip to content

feat(dependency-manifest.ts): add support for Dependabot commit messages#2584

Merged
ferrarimarco merged 7 commits intogoogleapis:mainfrom
guidev:fix-dependabot
Nov 4, 2025
Merged

feat(dependency-manifest.ts): add support for Dependabot commit messages#2584
ferrarimarco merged 7 commits intogoogleapis:mainfrom
guidev:fix-dependabot

Conversation

@guidev
Copy link
Contributor

@guidev guidev commented Aug 29, 2025

Refactor dependency update regex to support both Renovate and Dependabot commit message formats. Introduce a helper function matchCommit to handle regex matching for different dependency update tools. This change enables the versioning strategy to recognize and process dependency updates from multiple sources, improving compatibility and automation.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2295 🦕

@guidev guidev requested review from a team as code owners August 29, 2025 10:59
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Aug 29, 2025
Refactor regex matching to handle both Renovate and Dependabot commit
messages for dependency updates. This change allows the versioning
strategy to recognize and process dependency update commits from both
tools, enhancing compatibility and automation in dependency management.
Copy link
Collaborator

@ferrarimarco ferrarimarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for this PR.

Can you please implement a test for this in test/versioning-strategies/dependency-manifest.ts?

Thanks!

…DATE_REGEX

test(dependency-manifest.ts): add tests for dependabot dependency updates

Add tests to ensure correct version bumping for patch, minor, and major
updates. Include tests for both 'chore(deps)' and 'build(deps)' commit
messages.
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Sep 26, 2025
@guidev
Copy link
Contributor Author

guidev commented Sep 26, 2025

@ferrarimarco done!

@guidev guidev requested a review from ferrarimarco September 26, 2025 21:00
@guidev
Copy link
Contributor Author

guidev commented Oct 17, 2025

@ferrarimarco any update?

@ferrarimarco
Copy link
Collaborator

Thanks for the update. Reviewing now

Copy link
Collaborator

@ferrarimarco ferrarimarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor thing to check, and we shall be good to go. thanks

…EGEX to DEPENDENCY_UPDATE_REGEX for clarity and reuse
@guidev guidev requested a review from ferrarimarco November 3, 2025 18:42
@ferrarimarco
Copy link
Collaborator

@chingor13 can you please review this one? Thanks

@ferrarimarco ferrarimarco enabled auto-merge (squash) November 4, 2025 08:06
@ferrarimarco ferrarimarco merged commit 6a9ddb7 into googleapis:main Nov 4, 2025
10 checks passed
@guidev guidev deleted the fix-dependabot branch November 4, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make it compatible with dependabot bump messages

3 participants