Skip to content

docs: check autorelease: pending or autorelease: triggered in an old PR#1930

Merged
chingor13 merged 3 commits intogoogleapis:mainfrom
suztomo:patch-2
Sep 7, 2023
Merged

docs: check autorelease: pending or autorelease: triggered in an old PR#1930
chingor13 merged 3 commits intogoogleapis:mainfrom
suztomo:patch-2

Conversation

@suztomo
Copy link
Member

@suztomo suztomo commented Apr 20, 2023

@chingor13 I see we often encounter this situation where a label is needed to be removed from an old pull request. Adding the explanation to save our time.

In googleapis/java-logging-logback#1050, I had to remove the "autorelease: pending " label to create a release pull request.

…old PR

In googleapis/java-logging-logback#1050, I had to remove the "autorelease: pending " label to create a release pull request.
@suztomo suztomo requested review from a team as code owners April 20, 2023 15:11
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Apr 20, 2023
@suztomo
Copy link
Member Author

suztomo commented Apr 20, 2023

The checks are failing due to files I didn't touch: https://github.com/googleapis/release-please/actions/runs/4755928928/jobs/8450764116?pr=1930

node_modules/@octokit/core/dist-types/types.d.ts:1:31 - error TS7016: Could not find a declaration file for module '@octokit/types'. '/home/runner/work/release-please/release-please/node_modules/@octokit/types/dist-node/index.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/octokit__types` if it exists or add a new declaration (.d.ts) file containing `declare module '@octokit/types';`

1 import * as OctokitTypes from "@octokit/types";
                                ~~~~~~~~~~~~~~~~

node_modules/@octokit/graphql/dist-types/error.d.ts:1:33 - error TS70[16](https://github.com/googleapis/release-please/actions/runs/4755928928/jobs/8450764116#step:4:17): Could not find a declaration file for module '@octokit/types'. '/home/runner/work/release-please/release-please/node_modules/@octokit/types/dist-node/index.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/octokit__types` if it exists or add a new declaration (.d.ts) file containing `declare module '@octokit/types';`

1 import { ResponseHeaders } from "@octokit/types";
                                  ~~~~~~~~~~~~~~~~

@alex-enchi
Copy link
Contributor

The checks are failing due to files I didn't touch: https://github.com/googleapis/release-please/actions/runs/4755928928/jobs/8450764116?pr=1930

thats due version and types mismatch, see #1936

@chingor13 chingor13 enabled auto-merge (squash) September 5, 2023 16:15
@chingor13 chingor13 merged commit bd8dca5 into googleapis:main Sep 7, 2023
kalosisz added a commit to kalosisz/release-please that referenced this pull request Sep 19, 2023
chore(deps): update actions/checkout action to v4 (googleapis#2060)

docs: check `autorelease: pending` or `autorelease: triggered` in an old PR (googleapis#1930)

* docs: check `autorelease: pending` or `autorelease: triggered` in an old PR

In googleapis/java-logging-logback#1050, I had to remove the "autorelease: pending " label to create a release pull request.

* Update README.md

fix mismerge

---------

Co-authored-by: Jeff Ching <[email protected]>

test: also test on node 18 (googleapis#2063)

* test: also test on node 18

* ci: enable no-experimental-fetch for tests

* ci: set NODE_OPTIONS for node 18

* set NODE_OPTIONS for windows build

* set NODE_OPTIONS for windows build

ci: only require node 18 tests (googleapis#2065)

feat!: require node 18+ (googleapis#2069)

fix(deps): bump semver dependency version (googleapis#2068)

feat: Support pnpm workspaces (googleapis#2058)

fix(deps): replace lerna dependency with lerna-lite

Co-authored-by: Jeff Ching <[email protected]>

fix(deps): upgrade http-proxy-agent to v7 (googleapis#2071)

fix(deps): upgrade https-proxy-agent to v7

feat: fallback to root package version if package ignores github release (googleapis#1935)

Co-authored-by: Jeff Ching <[email protected]>

chore(deps): update dependency sinon to v16 (googleapis#2079)

feat: Use default updaters based on file extension (googleapis#2072)

* feat: Use default updaters based on file extension

* use CompositeUpdater

* improve things

---------

Co-authored-by: Jeff Ching <[email protected]>

chore(main): release 16.0.0 (googleapis#2070)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

config

docs
kalosisz added a commit to kalosisz/release-please that referenced this pull request Sep 19, 2023
chore(deps): update actions/checkout action to v4 (googleapis#2060)

docs: check `autorelease: pending` or `autorelease: triggered` in an old PR (googleapis#1930)

* docs: check `autorelease: pending` or `autorelease: triggered` in an old PR

In googleapis/java-logging-logback#1050, I had to remove the "autorelease: pending " label to create a release pull request.

* Update README.md

fix mismerge

---------

Co-authored-by: Jeff Ching <[email protected]>

test: also test on node 18 (googleapis#2063)

* test: also test on node 18

* ci: enable no-experimental-fetch for tests

* ci: set NODE_OPTIONS for node 18

* set NODE_OPTIONS for windows build

* set NODE_OPTIONS for windows build

ci: only require node 18 tests (googleapis#2065)

feat!: require node 18+ (googleapis#2069)

fix(deps): bump semver dependency version (googleapis#2068)

feat: Support pnpm workspaces (googleapis#2058)

fix(deps): replace lerna dependency with lerna-lite

Co-authored-by: Jeff Ching <[email protected]>

fix(deps): upgrade http-proxy-agent to v7 (googleapis#2071)

fix(deps): upgrade https-proxy-agent to v7

feat: fallback to root package version if package ignores github release (googleapis#1935)

Co-authored-by: Jeff Ching <[email protected]>

chore(deps): update dependency sinon to v16 (googleapis#2079)

feat: Use default updaters based on file extension (googleapis#2072)

* feat: Use default updaters based on file extension

* use CompositeUpdater

* improve things

---------

Co-authored-by: Jeff Ching <[email protected]>

chore(main): release 16.0.0 (googleapis#2070)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

config

docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants