Skip to content

feat: Manifest.createRelease to return PR numbers #2491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
suztomo merged 1 commit into from
Feb 27, 2025
Merged

feat: Manifest.createRelease to return PR numbers #2491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/manifest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,7 @@ export interface CreatedRelease extends GitHubRelease {
major: number;
minor: number;
patch: number;
prNumber: number;
}

export class Manifest {
Expand Down Expand Up @@ -1251,7 +1252,7 @@ export class Manifest {
// stop releasing once we hit an error
if (error) continue;
try {
githubReleases.push(await this.createRelease(release));
githubReleases.push(await this.createRelease(release, pullRequest));
} catch (err) {
if (err instanceof DuplicateReleaseError) {
this.logger.warn(`Duplicate release tag: ${release.tag.toString()}`);
Expand Down Expand Up @@ -1302,7 +1303,8 @@ export class Manifest {
}

private async createRelease(
release: CandidateRelease
release: CandidateRelease,
pullRequest: PullRequest
): Promise<CreatedRelease> {
const githubRelease = await this.github.createRelease(release, {
draft: release.draft,
Expand All @@ -1316,6 +1318,7 @@ export class Manifest {
major: release.tag.version.major,
minor: release.tag.version.minor,
patch: release.tag.version.patch,
prNumber: pullRequest.number,
};
}

Expand Down
3 changes: 3 additions & 0 deletions test/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,7 @@ describe('CLI', () => {
major: 1,
minor: 2,
patch: 3,
prNumber: 123,
},
]);
});
Expand Down Expand Up @@ -1178,6 +1179,7 @@ describe('CLI', () => {
major: 1,
minor: 2,
patch: 3,
prNumber: 123,
},
]);
});
Expand Down Expand Up @@ -1352,6 +1354,7 @@ describe('CLI', () => {
major: 1,
minor: 2,
patch: 3,
prNumber: 123,
},
]);
});
Expand Down
6 changes: 6 additions & 0 deletions test/manifest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5904,6 +5904,7 @@ describe('Manifest', () => {
expect(releases[0]!.sha).to.eql('abc123');
expect(releases[0]!.notes).to.eql('some release notes');
expect(releases[0]!.path).to.eql('.');
expect(releases[0]!.prNumber).to.eql(1234);
sinon.assert.calledOnce(commentStub);
sinon.assert.calledOnceWithExactly(
addLabelsStub,
Expand Down Expand Up @@ -6010,18 +6011,22 @@ describe('Manifest', () => {
expect(releases[0]!.sha).to.eql('abc123');
expect(releases[0]!.notes).to.be.string;
expect(releases[0]!.path).to.eql('packages/bot-config-utils');
expect(releases[0]!.prNumber).to.eql(1234);
expect(releases[1]!.tagName).to.eql('label-utils-v1.1.0');
expect(releases[1]!.sha).to.eql('abc123');
expect(releases[1]!.notes).to.be.string;
expect(releases[1]!.path).to.eql('packages/label-utils');
expect(releases[1]!.prNumber).to.eql(1234);
expect(releases[2]!.tagName).to.eql('object-selector-v1.1.0');
expect(releases[2]!.sha).to.eql('abc123');
expect(releases[2]!.notes).to.be.string;
expect(releases[2]!.path).to.eql('packages/object-selector');
expect(releases[2]!.prNumber).to.eql(1234);
expect(releases[3]!.tagName).to.eql('datastore-lock-v2.1.0');
expect(releases[3]!.sha).to.eql('abc123');
expect(releases[3]!.notes).to.be.string;
expect(releases[3]!.path).to.eql('packages/datastore-lock');
expect(releases[3]!.prNumber).to.eql(1234);
sinon.assert.callCount(commentStub, 1);
sinon.assert.calledOnceWithExactly(
addLabelsStub,
Expand Down Expand Up @@ -6078,6 +6083,7 @@ describe('Manifest', () => {
expect(releases[0]!.sha).to.eql('abc123');
expect(releases[0]!.notes).to.be.string;
expect(releases[0]!.path).to.eql('.');
expect(releases[0]!.prNumber).to.eql(1234);
sinon.assert.calledOnce(commentStub);
sinon.assert.calledOnceWithExactly(
addLabelsStub,
Expand Down
Loading