Skip to content

feat(java-yoshi-mono-repo): look for Version.java files #2730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chingor13 merged 1 commit into from
Apr 6, 2026
+26 −0
Merged

feat(java-yoshi-mono-repo): look for Version.java files #2730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/strategies/java-yoshi-mono-repo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,11 @@ export class JavaYoshiMonoRepo extends Java {
this.targetBranch,
this.path
);
const versionFilesSearch = this.github.findFilesByFilenameAndRef(
'Version.java',
this.targetBranch,
this.path
);

const pomFiles = await pomFilesSearch;
pomFiles.forEach(path => {
Expand Down Expand Up @@ -183,6 +188,19 @@ export class JavaYoshiMonoRepo extends Java {
});
});

const versionFiles = await versionFilesSearch;
versionFiles.forEach(path => {
updates.push({
path: this.addPath(path),
createIfMissing: false,
updater: new JavaUpdate({
version,
versionsMap,
isSnapshot: options.isSnapshot,
}),
});
});

this.extraFiles.forEach(extraFile => {
if (typeof extraFile === 'object') {
return;
Expand Down
8 changes: 8 additions & 0 deletions test/strategies/java-yoshi-mono-repo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,9 @@ describe('JavaYoshiMonoRepo', () => {
findFilesStub
.withArgs('README.md', 'main', '.')
.resolves(['path1/README.md', 'path2/README.md']);
findFilesStub
.withArgs('Version.java', 'main', '.')
.resolves(['path1/Version.java']);
const getFileContentsStub = sandbox.stub(
github,
'getFileContentsOnBranch'
Expand Down Expand Up @@ -285,6 +288,7 @@ describe('JavaYoshiMonoRepo', () => {
assertHasUpdate(updates, 'versions.txt', VersionsManifest);
assertHasUpdate(updates, 'path1/README.md', JavaUpdate);
assertHasUpdate(updates, 'path2/README.md', JavaUpdate);
assertHasUpdate(updates, 'path1/Version.java', JavaUpdate);
});

it('finds and updates extra files', async () => {
Expand Down Expand Up @@ -333,6 +337,9 @@ describe('JavaYoshiMonoRepo', () => {
findFilesStub
.withArgs('README.md', 'main', '.')
.resolves(['path1/README.md', 'path2/README.md']);
findFilesStub
.withArgs('Version.java', 'main', '.')
.resolves(['path1/Version.java']);
const getFileContentsStub = sandbox.stub(
github,
'getFileContentsOnBranch'
Expand Down Expand Up @@ -362,6 +369,7 @@ describe('JavaYoshiMonoRepo', () => {
assertHasUpdate(updates, 'versions.txt', VersionsManifest);
assertHasUpdate(updates, 'path1/README.md', JavaUpdate);
assertHasUpdate(updates, 'path2/README.md', JavaUpdate);
assertHasUpdate(updates, 'path1/Version.java', JavaUpdate);
});

it('updates changelog.json', async () => {
Expand Down
Loading