Conversation
|
Hello @jokerttu, I'm wondering if this MR is still in progress, as it has been submitted for approval for about a month? |
Yes, the process is still ongoing. |
9416e02 to
f944143
Compare
|
Excited for new arch support. Thank you for working on this - It will help our team resolve compatibility issues quickly. |
|
Any news on this? Maybe any planned dates for the release? |
|
Hello, any news on this? Do you guys have plan to merge it at some point or it's not a priority? Thanks! |
|
@eliabruni |
BREAKING CHANGE: React Native New Architecture support - See MIGRATING.md for upgrade guide - Convert NavView to Fabric component, NavModule/NavAutoModule to TurboModules - Replace onMapReady/onRecenterButtonClick callbacks with listener pattern - Refactor NavigationView props - Improve event listener pattern
686dafa to
46c622d
Compare
|
Hey Joonas! Reviewing this as-is is a bit challenging as there's different changes involved. Is it possible to split out PR's individually per change type? or at least have individual commits per change? |
illuminati1911
left a comment
There was a problem hiding this comment.
LGTM. Make sure to test that the Android Auto and especially CarPlay still works on the new architecture. I remember there was some issues before with CarPlay.
|
@ArturoSalazarB16
Also, would it be easier to review this by filtering out certain file types and checking them one by one? You can use GitHub's file filter in the "Files changed" tab to focus on specific extensions (e.g., .kt, .swift, .ts). |
Used a lot of time to improve Carplay and Android Auto support for this PR, and both works just fine! 🎉 |
Starting with React Native version 0.76, the New Architecture is enabled by default, introducing significant changes to the framework's internals. This PR updates the package to support the New Architecture and drops support for the legacy architecture.
Resolves #338
FEATURES:
7.1.0to7.3.010.6.0to10.7.0BREAKING CHANGES:
CHORE CHANGES:
Support Checklist (WIP)
Pre-launch Checklist