shouldCallXGoInit refactor

[xushiwei]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @xushiwei, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refactoring the internal logic for identifying and invoking XGo_Init methods on receiver types. By introducing a dedicated helper for method lookup and streamlining the shouldCallXGoInit function, the changes enhance code modularity and clarity in how receiver-bound methods are handled during code generation.

Highlights

• Refactored Method Lookup: Extracted the core logic for finding methods on a types.Type into a new, reusable function named findMethodByType.
• Improved shouldCallXGoInit Signature: The shouldCallXGoInit function was refactored to directly accept a *types.Var (representing the receiver), simplifying its interface and making its purpose clearer.
• Updated Call Sites: Adjusted the loadFuncBody function to utilize the new shouldCallXGoInit signature and directly reference the receiver variable (recv) when generating code for XGo_Init calls and base class method calls.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[codecov]

Codecov Report

❌ Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 93.96%. Comparing base (889c248) to head (d82163b).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
cl/classfile.go	87.50%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2583      +/-   ##
==========================================
+ Coverage   93.94%   93.96%   +0.01%     
==========================================
  Files          34       34              
  Lines        9809     9808       -1     
==========================================
+ Hits         9215     9216       +1     
+ Misses        423      422       -1     
+ Partials      171      170       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[gemini-code-assist]

Code Review

This pull request refactors the method lookup logic by extracting findMethodByType. The changes improve modularity and reuse. However, the extracted function findMethodByType has a bug where it only finds methods with value receivers, ignoring pointer receivers. I've suggested a fix for this. The rest of the refactoring, including the changes in loadFuncBody to use the actual receiver variable, looks good.

[xgopilot]

Review Summary

This is a well-structured refactoring that improves code reusability and eliminates redundant type assertions. The extraction of findMethodByType and the change from string-based VarVal("this") to direct Val(recv) are both positive improvements.

Key observations:

• Clean function extraction with appropriate separation of concerns
• Eliminates redundant Named → TypeName → Named type assertion chain
• Direct receiver variable access is more semantically correct than string lookup

One suggestion: Consider adding a nil guard in shouldCallXGoInit to maintain the defensive programming pattern from the original implementation.