Range Over Function Types

[xushiwei]

close #2607

[gemini-code-assist]

Summary of Changes

Hello @xushiwei, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the compileRangeStmt function to streamline the compilation of the range expression (v.X). By moving the compileExpr call for v.X outside of conditional blocks, it guarantees that the expression is processed consistently, irrespective of the presence of key or value variables in the for...range statement. Additionally, a small documentation correction was made in the ast package.

Highlights

• Refactoring compileRangeStmt: The compileExpr(ctx, 0, v.X) call within compileRangeStmt has been moved to ensure it is always executed exactly once, regardless of whether the for...range statement includes key or value variables.
• Documentation Cleanup: A minor correction was made in a comment within ast/ast_xgo.go, removing a redundant 'or' from the ComprehensionExpr documentation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• ast/ast_xgo.go
  • Removed a redundant 'or' from a comment describing ComprehensionExpr syntax.
• cl/stmt.go
  • Refactored compileRangeStmt to move the compileExpr(ctx, 0, v.X) call to a position where it is always executed once after the conditional handling of range variables, simplifying the compilation logic.

Activity

• No specific activity (comments, reviews) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.94%. Comparing base (45258ee) to head (777b2ec).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2606      +/-   ##
==========================================
- Coverage   93.95%   93.94%   -0.01%     
==========================================
  Files          33       33              
  Lines        9868     9867       -1     
==========================================
- Hits         9271     9270       -1     
  Misses        426      426              
  Partials      171      171              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[gemini-code-assist]

Code Review

This pull request introduces a clean and effective refactoring. The main change in cl/stmt.go correctly moves the compileExpr(ctx, 0, v.X) call out of an if-else block to eliminate code duplication, which improves maintainability. The minor comment adjustment in ast/ast_xgo.go is also a good cleanup. The changes are correct and well-contained. Nice work.

[xgopilot]

Code Review Summary ✅

This PR is a clean, well-executed refactoring that:

1. Applies DRY principle: Merges duplicate compileExpr(ctx, 0, v.X) calls from both if-else branches into a single call after the conditional block
2. Fixes documentation: Removes spurious trailing "or" from ComprehensionExpr comment

The refactoring is semantically equivalent - the expression v.X is still compiled at the same logical point relative to ForRangeEx and compileExprLHS operations. No security, performance, or correctness concerns identified.

Verdict: Approved - straightforward code consolidation that improves maintainability.