Skip to content

gogen v1.21.0: forRange support XGo_Enum() return iter.Seq/Seq2#2609

Merged
xushiwei merged 1 commit intogoplus:mainfrom
xushiwei:q
Feb 11, 2026
Merged

gogen v1.21.0: forRange support XGo_Enum() return iter.Seq/Seq2#2609
xushiwei merged 1 commit intogoplus:mainfrom
xushiwei:q

Conversation

@xushiwei
Copy link
Member

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @xushiwei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the goplus/gogen module to its v1.21.0 release. This update primarily enables enhanced forRange loop capabilities, allowing for more flexible iteration over XGo_Enum() results, which is showcased through the addition of new test files.

Highlights

  • gogen Version Update: The github.com/goplus/gogen dependency has been updated to v1.21.0, bringing the latest features and fixes.
  • Enhanced forRange Support: New test cases demonstrate improved forRange loop support for iterating over sequences returned by XGo_Enum(), specifically for iter.Seq/Seq2 types, as shown with dql.users.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • cl/_testgop/for-in/in.xgo
    • Added a new Go+ test file to demonstrate for-in loop functionality with dql objects.
  • cl/_testgop/for-in/out.go
    • Added the corresponding Go output file for the for-in loop test, illustrating the generated code.
  • go.mod
    • Updated the goplus/gogen module dependency from v1.20.10 to v1.21.0.
  • go.sum
    • Updated the cryptographic checksums for the goplus/gogen module to reflect the version upgrade.
Activity
  • No human activity (comments, reviews) has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates github.com/goplus/gogen to version v1.21.0, which introduces support for for-in loops over types implementing an XGo_Enum method returning iter.Seq/Seq2, and includes a corresponding test case. The changes are correct, and the dependency update and test files look good. A comprehensive security audit, including SAST analysis, found no vulnerabilities related to injection, hardcoded secrets, or access control.

@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.04%. Comparing base (179768a) to head (bf44579).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2609   +/-   ##
=======================================
  Coverage   94.04%   94.04%           
=======================================
  Files          33       33           
  Lines        9905     9905           
=======================================
  Hits         9315     9315           
  Misses        421      421           
  Partials      169      169           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xushiwei xushiwei merged commit b663e2d into goplus:main Feb 11, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments