Serialize session registry access per request - #295
Open
AshSgDe29071999 wants to merge 1 commit into
Open
Conversation
Concurrent Get calls on the same request raced on Registry.sessions and on replacing the request context. GraphQL subscriptions hitting sessions.Get from several goroutines could fatal with concurrent map writes. See gorilla#287
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #287
Concurrent
Geton the same*http.Request(typical of GraphQL subscriptions sharing a Gin context) raced in two places:GetRegistryreplaced*rwith a context-bearing copy without a lockRegistry.sessionswas a bare mapEither path can fatal with concurrent map writes. Guard registry attach with a mutex, and lock
Get/Saveon the per-request registry.