Fix debug logging regression bug affecting Command tests #1046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted by code under the resource package, but logging under system package still works.
|
@aelsabbahy could you approve this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced by commit 6a8fc96 (according to git bisect + testing ) that broke the logging detail that previously identified the child elements below the Command key. Examples are visible in #1015
Checklist
make test-all(UNIX) passes. CI will also test thisDescription of change
My understanding is that when using strings to identify context, the lookup worked fine. The pull request #922 that included commit 6a8fc96 didn't mention making this change explicitly, only that it included fixes to resolve some linting warnings. Since the code still compiled I think this bug went unnoticed.
Open to suggestions/feedback on the method to fix this bug 'correctly' if this implementation isnt the best.