Fix: Do not return full env map after downloading releases

[StrongMonkey]

After downloading gptscript release, we return a full map of current environment variables and this will eventuall get saved in to done.file, which will be picked up and saved as environment variable on the next run. This is causing weird issues like gptscript-ai/desktop#253. The original purpose of adding env variable to done.file is probably related to only append PATH, as we can see the logic here:

gptscript/pkg/repos/runtimes/golang/golang.go

Line 276 in 56b286b

newEnv := runtimeEnv.AppendPath(env, binPath)

. But this is not needed when downloading releases because it is always downloaded in known location.

[iwilltry42]

The go runtime is the only one even implementing the Binary() interface func, so I guess we could completely remove the env param, couldn't we?
Especially given your argument, that it doesn't make sense 😁

[StrongMonkey]

yes, I don't actually want to change too much scope just in case though.

[cjellick]

You dont think we're passing down anything else useful in these env vars?

[StrongMonkey]

You dont think we're passing down anything else useful in these env vars?

I looked at other code and the only thing we are doing is to pass PATH environment so that the binary we built is baked into the PATH. Which i don't think we needed for downloading releases. So I think this change should be good and darren did not include this intentionally.