add onPlayComplete
#187
Merged
add onPlayComplete
#187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aucahuasi
reviewed
Jun 14, 2025
aucahuasi
reviewed
Jun 14, 2025
aucahuasi
reviewed
Jun 14, 2025
aucahuasi
reviewed
Jun 14, 2025
| return throwError(() => new Error('playUpdates is not available the currently embedded graphistry viz.')); | ||
| } | ||
|
|
||
| const selectionPath = ".labels"; |
Contributor
There was a problem hiding this comment.
Out of curiosity, do we want to use .labels or .selection.labels here? Or are we going to create a new path for simulations to handle play updates?
Contributor
Author
There was a problem hiding this comment.
.labels already contains all the info required so thats the message thats being read
aucahuasi
requested changes
Jun 14, 2025
Contributor
aucahuasi
left a comment
aucahuasi
left a comment
There was a problem hiding this comment.
Thank you for this PR! See comments please.
aucahuasi
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.