fix: add horizon and subgraph-service as dependencies to toolshed#1210
Closed
pcarranzav wants to merge 3 commits intohorizonfrom
Closed
fix: add horizon and subgraph-service as dependencies to toolshed#1210pcarranzav wants to merge 3 commits intohorizonfrom
pcarranzav wants to merge 3 commits intohorizonfrom
Conversation
fix: add horizon and subgraph-service as dependencies to toolshed
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Member
Author
|
Actually, this doesn't work because it creates a circular dependency |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## horizon #1210 +/- ##
========================================
Coverage 82.84% 82.84%
========================================
Files 47 47
Lines 2093 2093
Branches 620 620
========================================
Hits 1734 1734
Misses 359 359
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@graphprotocol/horizonand@graphprotocol/subgraph-serviceas workspace dependencies to the toolshed packageworkspace:^protocol to ensure local packages are used during development and proper versions are resolved when publishedTest plan
🤖 Generated with Claude Code