Merged
Conversation
… and store IPFS metadata as token metadata
abarmat
force-pushed
the
ariel/gns-nft-descriptor
branch
from
5ac45c7 to
760a7ea
Compare
abarmat
changed the title
…ender into base58
abarmat
force-pushed
the
ariel/gns-nft-descriptor
branch
from
6bb2ed1 to
0a3888d
Compare
Codecov Report
@@ Coverage Diff @@
## dev #527 +/- ##
==========================================
+ Coverage 90.60% 91.19% +0.59%
==========================================
Files 35 37 +2
Lines 1703 1795 +92
Branches 282 293 +11
==========================================
+ Hits 1543 1637 +94
+ Misses 160 158 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
abarmat
force-pushed
the
ariel/gns-nft-descriptor
branch
from
2ac1aa8 to
cdac3a2
Compare
abarmat
added a commit
that referenced
this pull request
Jan 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the current implementation the GNS was turned into a NFT registry by adding the related state variables and behaviours through an upgrade. The upgrade is not yet done in mainnet. While testing in Rinkeby the team identified that some platforms (OpenSea, Etherscan, Rarible, etc.) couldn't properly identify a contract that was previously deployed as a non-NFT that was upgraded to be an NFT registry. That means that they won't display the NFT metadata properly.
The original implementation was done in the following PR: #497
Solution
Use composition instead of inheritance to add the NFT functionality.