feat(cli): add publish and mint using multicall#713
Conversation
Codecov ReportBase: 90.57% // Head: 90.57% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## dev #713 +/- ##
=======================================
Coverage 90.57% 90.57%
=======================================
Files 35 35
Lines 1762 1762
Branches 296 296
=======================================
Hits 1596 1596
Misses 166 166
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tmigone
left a comment
There was a problem hiding this comment.
Looks good. My only gripe is that I'd love to stop adding new commands to the cli and use hardhat tasks instead, but we can migrate them later as well.
| ipfs: string, | ||
| type: string, | ||
| path?: string, // Only pass path or metadata, not both | ||
| filepath?: string, // Only pass path or metadata, not both |
There was a problem hiding this comment.
I was curious if there was a ts trick to require only one of two properties:
type RequireOnlyOne<T, Keys extends keyof T = keyof T> =
Pick<T, Exclude<keyof T, Keys>>
& {
[K in Keys]-?:
Required<Pick<T, K>>
& Partial<Record<Exclude<Keys, K>, undefined>>
}[Keys]
I think we can stick with your code 😆
No description provided.