fix: validate Arbitrum addresses and callhook senders are contracts (OZ L-01 from #700)#734
Merged
pcarranzav merged 1 commit intopcv/l2-bridgefrom Nov 10, 2022
Conversation
Codecov ReportBase: 91.57% // Head: 91.59% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## pcv/700-699-m01-validation-before-unpause #734 +/- ##
=============================================================================
+ Coverage 91.57% 91.59% +0.01%
=============================================================================
Files 42 42
Lines 1995 1998 +3
Branches 354 357 +3
=============================================================================
+ Hits 1827 1830 +3
Misses 168 168
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tmigone
approved these changes
Oct 21, 2022
| await getAccounts() | ||
|
|
||
| // Dummy code on the mock router so that it appears as a contract | ||
| await provider().send('hardhat_setCode', [mockRouter.address, '0x1234']) |
abarmat
approved these changes
Oct 27, 2022
pcarranzav
changed the base branch from
pcv/700-699-m01-validation-before-unpause
to
pcv/l2-bridge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.