Use signalledTokens instead of signalAmount for minSignal threshold#367
Merged
Use signalledTokens instead of signalAmount for minSignal threshold#367
Conversation
The `signalledTokens` field describes the amount of GRT signalled on a subgraph or subgraph deployment. `signalAmount` describes the amount of signal shares on a subgraph, which is based on the bonding curve and hence don't correspond 1:1 to the amount of GRT signalled. It is therefore much more intuitive to use `signalledTokens` for the `minSignal` threshold in indexing rules.
Jannis
changed the title
hopeyen
approved these changes
Feb 22, 2022
Contributor
hopeyen
left a comment
hopeyen
left a comment
There was a problem hiding this comment.
The change makes sense to me. re-ran jobs and agent image was able to build :)
abarmat
approved these changes
Feb 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
signalledTokensfield describes the amount of GRT signalled on a subgraph or subgraph deployment.signalAmountdescribes the amount of signal shares on a subgraph, which is based on the bonding curve and hence don't correspond 1:1 to the amount of GRT signalled.It is therefore much more intuitive to use
signalledTokensfor theminSignalthreshold in indexing rules.