fix: Not to bind core for connectionPlugin#1142
Open
potsbo wants to merge 1 commit intographql-nexus:mainfrom
Open
fix: Not to bind core for connectionPlugin#1142potsbo wants to merge 1 commit intographql-nexus:mainfrom
potsbo wants to merge 1 commit intographql-nexus:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In typegen print process, using
connectionPluginalways importscorefromnexuseven though the plugin doesn’t require.Fixes
I tried to fix this by removing
corefromconnectionPluginbindings. However doing so leads to not importingcorein any circumstances, which is sometimes required whendynamicInputFieldsand/ordynamicOutputFieldsis present. So I dug a bit deeper to find out following.In current implementation,
maybeAddCoreImportis called only whenthis.printImports[nexusSchemaImportId]isundefined, which basically means that there is no one configuringimportfromnexuspackage. I believe the origin of this behavior comes from this change.This behavior is the reason why
corewas omitted when fixingbindingsinconnectionPlugin, because it tries to configureimportfromnexus.Speculation about backward compatibility
The current behavior was introduced because of backward compatibility, which I think means not to break any current schema that manually importing
core. If so, I believe my fix is better for those people because this can lead them to better state with less config.