Skip to content

fix: don't loose extensions of enum values when sorting schemas#245

Merged
Cito merged 1 commit into
graphql-python:mainfrom
erikwrede:fix-keep-enum-value-extensions-on-lex-sorting
Oct 24, 2025
Merged

fix: don't loose extensions of enum values when sorting schemas#245
Cito merged 1 commit into
graphql-python:mainfrom
erikwrede:fix-keep-enum-value-extensions-on-lex-sorting

Conversation

@erikwrede

@erikwrede erikwrede commented Oct 24, 2025

Copy link
Copy Markdown
Member

When sorting a schema lexicographically, the enum values lost their extensions.

@codspeed-hq

codspeed-hq Bot commented Oct 24, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #245 will not alter performance

Comparing erikwrede:fix-keep-enum-value-extensions-on-lex-sorting (72e6445) with main (4b0ada2)

Summary

✅ 14 untouched

@Cito

Cito commented Oct 24, 2025

Copy link
Copy Markdown
Member

Thank you @erikwrede

@Cito Cito merged commit 431b0f5 into graphql-python:main Oct 24, 2025
14 checks passed
@Cito Cito changed the title fix: don't loose extensions when sorting enum values lexicographically. fix: don't loose extensions of enum values when sorting schemas Oct 24, 2025
@Cito

Cito commented Oct 24, 2025

Copy link
Copy Markdown
Member

Actually input values and the schema itself had the same problem, fixed that already, and backported it as well.

@erikwrede

Copy link
Copy Markdown
Member Author

@Cito still meant to check for that, great you found it first :) thanks for the quick merge

@Cito

Cito commented Apr 21, 2026

Copy link
Copy Markdown
Member

Just for the records: We overlooked that the same problem existed for the deprecation reason and out name, but this has been fixed now as well with #264.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants