docs: move migrate from express graphql guide to graphqlJS docs#4433
docs: move migrate from express graphql guide to graphqlJS docs#4433sarahxsanders wants to merge 7 commits intographql:16.x.xfrom
Conversation
yaacovCR
left a comment
yaacovCR
left a comment
There was a problem hiding this comment.
Thanks for all your amazing work on the docs! Made a few scattered comments just to think about.
|
Thank you @yaacovCR for your thoughtful feedback! I have addressed it in my recent commit. Let me know if you spot anything else :) |
Co-authored-by: Yaacov Rydzinski <yaacovCR@gmail.com>
benjie
left a comment
benjie
left a comment
There was a problem hiding this comment.
Really nice article. Maybe the "Consider IDE support in development" section wants removing or merging with the "Step 5: Add a GraphQL IDE (optional)" section?
@enisdenjo can you sign off on the accuracy of the steps provided?
|
If @enisdenjo confirms the migration steps look good, I approve 👍 |
|
You don't seem to have pushed any more commits... But I also notice that GitHub is having issues so maybe you have and they're just not showing up yet. |
|
@benjie sorry about that! I have been having internet troubles and my commit got lost somewhere. just pushed it now :) |
benjie
left a comment
benjie
left a comment
There was a problem hiding this comment.
Looks good to me, but @enisdenjo might want to do a final confirmation 👍
5 participants
Resolves this feedback: graphql/graphql.github.io#2005 (review)
Moving Migrate from express graphQL guide to graphQL-js