Standardize struct + typedef usage.#1704
Open
antoinevg wants to merge 4 commits intogreatscottgadgets:mainfrom
Open
Standardize struct + typedef usage.#1704antoinevg wants to merge 4 commits intogreatscottgadgets:mainfrom
struct + typedef usage.#1704antoinevg wants to merge 4 commits intogreatscottgadgets:mainfrom
Conversation
65b74ca to
ac4edd5
Compare
d97be1f to
943a600
Compare
This was referenced Apr 2, 2026
Closed
943a600 to
046b6a7
Compare
martinling
approved these changes
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1703
This PR standardizes
structdefinitions for HackRF firmware and resolves the ambiguity between declarations such asstruct type_tandtypedef struct type_t type_tWe prefer two formats:
1. Simple
structdefinitions:structdefinitions of the form:are refactored to:
2. Self-referential
structdefinitions:Self-referential definitions of the form:
are refactored to: