Skip to content

More pre-commit and validate-pyproject#38

Merged
greenbender merged 2 commits intogreenbender:mainfrom
cclauss:more-pre-commit
Sep 23, 2024
Merged

More pre-commit and validate-pyproject#38
greenbender merged 2 commits intogreenbender:mainfrom
cclauss:more-pre-commit

Conversation

@cclauss
Copy link
Copy Markdown
Contributor

@cclauss cclauss commented Sep 22, 2024

Ensure files remain tidy and pyproject.toml is valid.

Comment thread .pre-commit-config.yaml Outdated
- id: check-added-large-files
- id: check-ast
- id: check-builtin-literals
- id: check-byte-order-marker
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check-byte-order-marker appears to be deprecated

Comment thread .pre-commit-config.yaml
# - id: pretty-format-json
- id: requirements-txt-fixer
- id: sort-simple-yaml
- id: trailing-whitespace
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding no-commit-to-branch would be useful. I often make this mistake.

Comment thread .pre-commit-config.yaml Outdated
Comment thread .pre-commit-config.yaml
@cclauss
Copy link
Copy Markdown
Contributor Author

cclauss commented Sep 23, 2024

A nice weekend of work! Thanks massively.

@greenbender greenbender merged commit d55dcaa into greenbender:main Sep 23, 2024
@greenbender
Copy link
Copy Markdown
Owner

Thank you for all your help! Huge improvements to this repo. Expect release 2.0.0 when I get a little time. Next weekend maybe.

@cclauss cclauss deleted the more-pre-commit branch September 23, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants