This repository was archived by the owner on Jul 16, 2024. It is now read-only.
fix: pipeline down#35
Merged
Merged
Conversation
Sasasu
approved these changes
Mar 30, 2022
Sasasu
reviewed
Mar 30, 2022
| resources: | ||
| # Image Resources | ||
| - name: centos-gpdb-dev-7 | ||
| type: docker-image |
Member
There was a problem hiding this comment.
Suggested change
| type: docker-image | |
| type: registry-image |
we can use registry-image to get a colorful log.
and releng team like registry-image because it has less pull frequency
Sasasu
reviewed
Mar 30, 2022
| tag: latest | ||
|
|
||
| - name: ubuntu18-image-test | ||
| type: docker-image |
Member
There was a problem hiding this comment.
Suggested change
| type: docker-image | |
| type: registry-image |
same here.
Sasasu
reviewed
Mar 30, 2022
| tag: latest | ||
|
|
||
| - name: ubuntu18-image-test | ||
| type: docker-image |
Member
There was a problem hiding this comment.
and here
just run sed -i s/docker-image/registry-image/g
Contributor
Author
There was a problem hiding this comment.
Cool, learned that~
beeender
reviewed
Mar 30, 2022
Contributor
beeender
left a comment
beeender
left a comment
There was a problem hiding this comment.
BIG THANKS for fixing this!
| region_name: ((aws-region)) | ||
| secret_access_key: ((bucket-secret-access-key)) | ||
| versioned_file: plugin-cache.tgz | ||
| type: s3 |
Contributor
There was a problem hiding this comment.
This is OK. in the gp-concourse-cluster-provisioner examples, the terraform.d resource is still using s3.
beeender
approved these changes
Mar 31, 2022
reasons: 1. url link change from pivotal -> gcr.io 2. now we need to use terraform.d 3. some ccp env changed
yihong0618
force-pushed
the
pipeline_fix
branch
from
a6e204f to
fb54c0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.