Skip to content

fix: embed external deps#1286

Merged
afshinm merged 1 commit intomasterfrom
umd-fix
Jan 16, 2023
Merged

fix: embed external deps#1286
afshinm merged 1 commit intomasterfrom
umd-fix

Conversation

@afshinm
Copy link
Copy Markdown
Member

@afshinm afshinm commented Jan 16, 2023

Fixes #1282

@afshinm afshinm added the bug fix Something isn't working label Jan 16, 2023
@afshinm
Copy link
Copy Markdown
Member Author

afshinm commented Jan 16, 2023

Fixes #1281

@afshinm afshinm marked this pull request as ready for review January 16, 2023 21:51
@github-actions
Copy link
Copy Markdown

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 79.93% 1294/1619
🟡 Branches 66.54% 346/520
🟢 Functions 81.05% 278/343
🟡 Lines 79.58% 1138/1430

Test suite run success

176 tests passing in 31 suites.

Report generated by 🧪jest coverage report action from 81660e8

@github-actions
Copy link
Copy Markdown

Size Change: +22.2 kB (+31%) 🚨

Total Size: 94.2 kB

Filename Size Change
dist/gridjs.js 16.3 kB +4.45 kB (+38%) 🚨
dist/gridjs.module.js 16.3 kB +4.49 kB (+38%) 🚨
dist/gridjs.production.es.min.js 16.3 kB +4.49 kB (+38%) 🚨
dist/gridjs.production.min.js 16.3 kB +4.39 kB (+37%) 🚨
dist/gridjs.umd.js 16.3 kB +4.39 kB (+37%) 🚨
ℹ️ View Unchanged
Filename Size
l10n/dist/l10n.js 3.05 kB
l10n/dist/l10n.module.js 3.13 kB
l10n/dist/l10n.umd.js 3.18 kB
plugins/selection/dist/selection.js 1.05 kB
plugins/selection/dist/selection.module.js 1.08 kB
plugins/selection/dist/selection.umd.js 1.16 kB

compressed-size-action

@afshinm afshinm merged commit 560e074 into master Jan 16, 2023
@afshinm afshinm deleted the umd-fix branch January 16, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new gridjs.Grid({ is not a constructor

1 participant