Skip to content

fix: deepEqual exceed maximum call stack size#1428

Merged
afshinm merged 1 commit intogrid-js:masterfrom
ryuapp:deep-equal-adapt-vnode
Mar 3, 2024
Merged

fix: deepEqual exceed maximum call stack size#1428
afshinm merged 1 commit intogrid-js:masterfrom
ryuapp:deep-equal-adapt-vnode

Conversation

@ryuapp
Copy link
Copy Markdown
Contributor

@ryuapp ryuapp commented Feb 20, 2024

fix #1422

VNode has too many properties and will cause the error on deepEqual, so make sure to only compare props.

@ryuapp ryuapp changed the title Fix deepEqual exceed maximum call stack size fix: deepEqual exceed maximum call stack size Feb 20, 2024
@afshinm afshinm merged commit 79124b2 into grid-js:master Mar 3, 2024
@afshinm
Copy link
Copy Markdown
Member

afshinm commented Mar 3, 2024

Thanks @ryuapp!

@afshinm afshinm added the bug fix Something isn't working label Mar 3, 2024
@ryuapp ryuapp deleted the deep-equal-adapt-vnode branch March 5, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maximum call stack size exceeded error when search is enabled and columns use gridjs.html for formating

2 participants