Conversation
|
One possible issue with this way of doing things is that deb822 is now used unconditionally everywhere. I think it's been supported since Jessie, but it might not be desirable to use it in anything older than Trixie. |
|
@zeha maybe that's something we might wanna unify now for an upcoming version of grml-debootstrap + Grml release? What's your take on old/single-line format vs. deb822? |
|
DEB822-STYLE FORMAT is the future. Quote https://manpages.debian.org/trixie/apt/sources.list.5.en.html
|
Yes, but as @ArrayBolt3 wrote:
So we should decide when (in terms of which Debian releases) to use deb822 format. |
|
I think now is fine. |
As in: switch it for trixie and newer? |
No, just for everything we support (which is bullseye and newer). But obviously it should then work for all the releases. |
zeha
left a comment
There was a problem hiding this comment.
Please leave the packer/* files alone.
e63483f to
da46e1a
Compare
This should be a relatively straightforward change. I went through all files searching for
listanddeb, porting any one-line format code to deb822 as I went.Unfortunately, the most complex bit of code, the
deletesourcefunction inchroot-script, has not been tested in an actual VM build, as I'm not sure how to even trigger it.$MIRRORhas to be afile:URL forremove_chrootmirrorto be called, and that's the only function that callsdeletesource. But for$MIRRORto be afile:URL, the contents of the mirror would have to be signed by the Debian archive keyring, which means I'd need to clone the Debian archive or some substantial portion thereof, which I don't currently know how to do. I have testeddeletesourcein an interactive Bash shell and it seems to work in a couple of scenarios (copy/usr/share/doc/apt/examples/debian.sourcesto your home dir, then trydeletesource ~/debian.sources 'deb' 'http://deb.debian.org/debian' 'trixie trixie-updates' 'main contrib non-free non-free-firmware' '/usr/share/keyrings/debian-archive-keyring.gpg'anddeletesource ~/debian.sources 'deb' 'http://deb.debian.org/debian-security' 'trixie-security', see what happens to the file).I also did not test
packer/debian64_provision.shas I don't know how it's intended to be used. It looks like it's part of Grml's CI system?Fixes #203.