Skip to content

chore(audit): remove vendored Firebase and Xcode agent skills - #2558

Merged
kk-agent merged 2 commits into
mainfrom
cursor/remove-firebase-xcode-skills-83be
Nov 4, 2026
Merged

kk-agent merged 2 commits into
mainfrom
cursor/remove-firebase-xcode-skills-83be

Conversation

@kk-agent

@kk-agent kk-agent commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Removes the vendored Firebase and Xcode agent skills and the wiring that only exists for them.

Related: #2328

Findings

  • Done: .agents/skills/firebase-* (10 skills, 79 tracked files). rg firebase found no match in apps/web/package.json, root package.json, or pyproject.toml. No firebase.json or .firebaserc.
  • Done: .agents/skills/xcode-project-setup/ (4 files, including Package.swift and main.swift). git ls-files '*.swift' 'Package.swift' is empty after the delete. No other Swift/iOS paths were tracked.
  • Done: 11 symlinks under .claude/skills/ that pointed at those skills. Other .claude/skills symlinks are unchanged.
  • Done: .gemini/extensions/firebase/** (3 files). gemini-extension.json hardcoded /Users/garvey/Dev/EventRelay.
  • Done: firebase/agent-skills entries in skills-lock.json (10 Firebase skills plus xcode-project-setup).
  • Skipped: one-line host-config reference. GEMINI.md MCP table has no Firebase or Xcode skill row. No other host-config line named these skills or the Gemini Firebase extension.

Remaining firebase hits (left in place)

  • tests/unit/test_skills_event_validator.py inline v1 lock fixture named firebase-basics. It does not load the skill files.
  • .vscode/extensions.json recommends googlecloudtools.firebase-dataconnect-vscode.
  • .github/agent/rules/how-to-video-text.md links Firebase AI Logic docs.
  • EventRelay-Full-System-Breakdown.md lists firebase/firestore.json and firebase/auth_config.json. The docs/ copy of that file was out of the cleanup scan.
  • shared/_core/MISSION_BLUEPRINT_REF.md diagram labels, and shared/_core/PROJECT_DECISIONS.md cites github.com/firebase/genkit.
  • .firebase/.graphqlrc points at a missing dataconnect/ tree. It is not skill wiring.

Verification

PYTHONPATH=src python3 -m pytest tests/unit/test_skills_event_validator.py tests/test_skills_integration.py -q -o addopts='' -p no:ddtrace — 75 passed.

No web or Python source files changed, so npm ci, npm run build, npm run lint, and npm test were not run locally. GitHub CI covers those jobs. Not merged.

Open in Web Open in Cursor 

Closes #2577

Delete the unused Firebase and Xcode agent skills, their Claude
symlinks, the Gemini Firebase extension, and the matching
skills-lock.json entries.

Co-authored-by: KK <kk-agent@users.noreply.github.com>
@vercel

vercel Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
v0-uvai Ready Ready Preview, v0 Nov 4, 2026 7:12am UTC

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

🔍 PR Validation

⚠️ Large PR detected (10977 lines changed)

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-03T16:05:31.503544Z 02359f9 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

⚠️ Repository reconciliation: this PR does not reference exactly one canonical issue.

Please add a Closes #<issue> reference in the PR description so it can be tracked against the delivery plan.

See governance: #898

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

  • .agents/skills/xcode-project-setup/scripts/xcode_spm_setup/Package.resolved

@kk-agent
kk-agent merged commit f3b63ce into main Nov 4, 2026
32 of 33 checks passed
@kk-agent
kk-agent deleted the cursor/remove-firebase-xcode-skills-83be branch November 4, 2026 08:58

This branch was successfully deployed

1 active deployment
Preview — 9918af2f Deployed Nov 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Audit cleanup: chore(audit): remove vendored Firebase and Xcode agent skills

3 participants