Repository navigation
chore(audit): delete unimported apps/web/src/lib modules - #2561
Merged
Merged
Conversation
Remove web lib modules with no importer, their exclusive tests, and unused error-handling exports. Drop the stale models.py sync sentence from types.ts. Co-authored-by: KK <kk-agent@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
github-actions
Bot
added
javascript
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
Please add a See governance: #898 |
Contributor
🔍 PR Validation |
Contributor
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
Contributor
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Delete unimported
apps/web/src/libmodules and dead exports. No modules, wrappers, or docs were added.Related: #2328
Findings
Re-checked with
rgonmain(cd7e1998f) before editing. None skipped.apps/web/src/lib/agent-pipeline.ts. No importer. It definessimulatePipelineand the hard-coded strings12,400 wordsand142 key frames.apps/web/src/lib/workflow-templates.ts.WORKFLOW_TEMPLATEShad no importer.apps/web/src/lib/studio-shell-storage.ts.studioShellStoragePrefixhad no importer.apps/web/src/lib/services/agent-service.ts,event-service.ts, andvideo-service.ts. No importer outside this deleted set.apps/web/src/lib/api-client.tsandapps/web/src/lib/__tests__/api-client.test.ts. Imported only by those three services.apps/web/src/lib/ai-gateway-rag.ts.findRelevantGatewayContenthad no importer.apps/web/src/lib/services/builtin-ai.ts,apps/web/src/hooks/use-builtin-ai.ts, andapps/web/src/hooks/__tests__/use-builtin-ai.test.ts. The hook was imported only by its test.apps/web/src/lib/event-extraction-service.ts. No importer. Its comment names route callers that do not import it.src/youtube_extension/backend/api/v1/models.pyis not in the tree.apps/web/src/lib/error-handling.ts. RemovedCircuitBreaker,withTimeout, andvalidateRequiredFields. KeptretryWithBackoff,parseJsonSafely, andformatApiError.apps/web/src/lib/types.ts. Removed the models.py sync sentence. The types are unchanged.After the edit,
rgoverapps/web*.{ts,tsx,js,jsx,mjs}found no matches for the deleted module names or the removed exports.Verification
Head
28052d5ad.npm ci --legacy-peer-depssucceeded.npm run lint --workspace=apps/webpassed. CIlint-frontendpassed.npm run type-check --workspace=apps/webpassed.npm run build:webpassed.ORIGIN_GATE_REDIS_TESTS=1 npm --workspace=apps/web test: 173 files passed, 1 failed; 1552 tests passed, 2 failed, 1 skipped.test-frontendfailed the same two tests inhome-sell-surface.test.ts. They assert copy inapp/page.tsx. This diff does not change that file.Not merged. Auto-merge was not enabled.
Closes #2579