Skip to content

chore(audit): remove fake-success skills and hybrid mock path - #2566

Merged
kk-agent merged 3 commits into
mainfrom
cursor/remove-fake-success-skills-d08b
Nov 4, 2026
Merged

chore(audit): remove fake-success skills and hybrid mock path#2566
kk-agent merged 3 commits into
mainfrom
cursor/remove-fake-success-skills-d08b

Conversation

@kk-agent

@kk-agent kk-agent commented Nov 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Outcome

A missing Gemini key no longer becomes a successful AI result. The seven BaseSkill packages that logged a future Gemini call and returned generated: True / queued success are gone, and the hybrid processor returns a failure when Gemini is unavailable.

Findings

  • src/skills/** fake-success packages: done. Deleted content_generation, email_campaign, seo_optimizer, analytics_dashboard, lead_scorer, ab_testing, social_scheduler, and base.py. Deleted tests/test_skills_integration.py, the only test that covered that tree. Removed the matching uvai-skills entries from skills-lock.json and config/agent_network.json so discovery cannot load the deleted modules.
  • hybrid_processor_service.py mock success path: done. Deleted _generate_mock_response, enable_mock, and YOUTUBE_EXTENSION_MOCK_AI. Unavailable Gemini now returns success=False, response=None, error="Gemini not available or not initialized". Deleted _record_api_usage (it imported the already-removed api_cost_monitor) and the usage-tracking call that depended on it. ProcessingMode is only CLOUD_ONLY. Dropped the compatibility header.
  • Delete the hybrid module entirely: skipped. rg still finds importers in services/ai/__init__.py, hybrid_vision_agent.py, personality_agent.py, strategy_agent.py, transcript_action_agent.py, and tests/unit/test_agent_adapters.py.
  • YOUTUBE_EXTENSION_MOCK_AI: done. rg on current main found it only in the hybrid service and tests/unit/test_hybrid_processor_service.py. Both references are removed. No env-example hits.
  • Historical docs that still mention src/skills/ or uvai-skills (docs/ARCHITECTURE_DIAGRAM.md, triage notes): skipped. They are not live success paths.

Related: #2328

Verification

  • rg YOUTUBE_EXTENSION_MOCK_AI and rg 'backend="mock"|_generate_mock_response' outside docs: no matches after the change.
  • python3 -m compileall -q src/ passed.
  • PYTHONPATH=src python3 -m pytest tests/unit/ -q --timeout=120 --cov=src/youtube_extension --cov-fail-under=0 --ignore=tests/unit/test_transcript_action_workflow.py -k "not integration": 3027 passed, 11 failed. The 11 failures are tests/unit/test_dependency_review_workflow.py because this environment has no python binary (bash: python: command not found). Re-ran that file with python on PATH: 20 passed. Hybrid processor tests passed in the same run.
  • PYTHONPATH=src python3 -m pytest tests/security/test_local_mcp_config.py tests/security/test_mcp_catalog_approval.py -q -o addopts='': passed (included in the 130-passed follow-up run).
  • No web files changed, so npm ci / npm run build / npm run lint / npm test were not run locally.
  • GitHub build, guards, lint-python, and the Python test jobs passed on this head. report passed on the rerun after the body edit (an earlier run was cancelled).

Checks left red

test-frontend fails on this head for a reason already on main: apps/web/src/lib/__tests__/home-sell-surface.test.ts expects prepares proposed work and build rails for you to review in Studio, and apps/web/src/app/page.tsx says Studio prepares proposed work and build rails for you to review. This diff does not touch apps/web. Left unchanged.

No merge. Hayden merges.

Open in Web Open in Cursor 

Closes #2583

@cursoragent @kk-agent
chore(audit): remove fake-success skills and hybrid mock path
67fde9d 
Delete the seven BaseSkill packages that reported success without a
model call, and return a Gemini-unavailable failure instead of mock JSON.

Co-authored-by: KK <kk-agent@users.noreply.github.com>
@vercel

vercel Bot commented Nov 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
v0-uvai Ready Ready Preview, v0 Nov 4, 2026 9:50am UTC

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-11-04T09:48:01.416123Z
We couldn’t complete this review. Comment @codex review to try again.		 b5c0767 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot added the python label Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🔍 PR Validation

⚠️ Large PR detected (1601 lines changed)

@github-actions github-actions Bot mentioned this pull request Nov 3, 2026
Open
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

⚠️ Repository reconciliation: this PR does not reference exactly one canonical issue.

Please add a Closes #<issue> reference in the PR description so it can be tracked against the delivery plan.

See governance: #898

@groupthinking
Merge main into cursor/remove-fake-success-skills-d08b
fe34692 
Resolve config/agent_network.json against #2565: keep main's tool edits and
drop the seven uvai-skills agents and the gtm-skills server, as this PR intends.
@kk-agent kk-agent mentioned this pull request Nov 4, 2026
Closed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@kk-agent
kk-agent merged commit d26fedb into main Nov 4, 2026
30 checks passed
@kk-agent
kk-agent deleted the cursor/remove-fake-success-skills-d08b branch November 4, 2026 10:04
@groupthinking groupthinking mentioned this pull request Nov 4, 2026
Closed

This branch was successfully deployed

1 active deployment
Preview — b5c0767e Deployed Nov 4, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@groupthinking groupthinking Awaiting requested review from groupthinking groupthinking is a code owner

Assignees

No one assigned

Labels

python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Audit cleanup: chore(audit): remove fake-success skills and hybrid mock path

4 participants

@kk-agent @cursoragent @groupthinking @xxxxxxxxxxxxx