feat: duplicate export confirmation#10778
Closed
Ryosei-Fukushima wants to merge 12 commits intofeat/94790-audit-log-bulk-exportfrom
Closed
feat: duplicate export confirmation#10778Ryosei-Fukushima wants to merge 12 commits intofeat/94790-audit-log-bulk-exportfrom
Ryosei-Fukushima wants to merge 12 commits intofeat/94790-audit-log-bulk-exportfrom
Conversation
…hoose whether to retry or confirm
Ryosei-Fukushima
changed the title
…tors-can-request-export-by-clicking-the-export-button feat: administrator can request an export from the audit log bulk export modal
… into feat/94790-178338-duplicate-export-confirmation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://redmine.weseek.co.jp/issues/178338
AuditLogManagement.tsx のみ前タスクの差分のため、レビュー対象外です。
前タスク: https://redmine.weseek.co.jp/issues/172039
実装内容
同じ条件で再度リクエストした場合の挙動を修正しました。
まだ完了していないジョブ が同じ filterHash で存在している場合、今までは確認されずに再実行されていましたが、
「エクスポートをやり直しますか？」 の確認アラートを作成。
ユーザーが OK を押した場合は /audit-log-bulk-export の restartJob: true を付けて再実行します。