grpc-js: tests: skip checking for IPv6 addresses from DNS servers#1297
Merged
murgatroid99 merged 1 commit intogrpc:masterfrom Mar 10, 2020
Merged
Conversation
nicolasnoble
approved these changes
Mar 10, 2020
Member
Author
|
nodejs/node#32183 has some changes that should allow us to enable these tests again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #1289. I think this is the right way to move forward until changes can be made to Node itself to allow us to get AAAA records more consistently using
dns.lookup.