tests: Add Claude agents for API testing#934
Open
matejnesuta wants to merge 2 commits intoguacsec:mainfrom
Open
tests: Add Claude agents for API testing#934matejnesuta wants to merge 2 commits intoguacsec:mainfrom
matejnesuta wants to merge 2 commits intoguacsec:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #934 +/- ##
==========================================
- Coverage 65.07% 64.14% -0.93%
==========================================
Files 195 195
Lines 3341 3341
Branches 753 753
==========================================
- Hits 2174 2143 -31
- Misses 868 908 +40
+ Partials 299 290 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Reviewer's GuideAdds four Claude agent configuration files that define an automated workflow for generating, reviewing, orchestrating, and analyzing Playwright API tests for Trustify UI, including detailed responsibilities, standards, and processes for each agent. Sequence diagram for orchestrated API test generation and analysissequenceDiagram
actor Developer
participant Orchestrator as api-test-orchestrator
participant Analyzer as api-coverage-analyzer
participant Generator as api-test-generator
participant Reviewer as api-test-reviewer
participant Spec as OpenAPI_trustd_yaml
participant Tests as Api_test_files
Developer ->> Orchestrator: Define testing goal
Orchestrator ->> Analyzer: Analyze API coverage
Analyzer ->> Spec: Read OpenAPI spec
Analyzer ->> Tests: Read existing API tests
Analyzer -->> Orchestrator: Coverage report + prioritized gaps
Orchestrator ->> Generator: Generate tests for top priority gaps
Generator ->> Spec: Read OpenAPI spec
Generator ->> Tests: Read existing tests for context
Generator -->> Developer: Draft Playwright API tests
Developer ->> Reviewer: Submit draft tests for review
Reviewer ->> Spec: Cross check against OpenAPI spec
Reviewer ->> Tests: Compare with existing patterns
Reviewer -->> Developer: Review comments and improvements
Developer ->> Tests: Integrate approved tests into suite
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- There’s a lot of duplicated guidance between the generator, reviewer, orchestrator, and coverage analyzer (e.g., URLSearchParams usage, Jira bugfix format, file locations); consider extracting shared standards into a single short reference section that each agent links to so future updates don’t get out of sync.
- Some of the embedded code examples (e.g.,
const fs = require('fs');, specificnpmcommands, and relative paths) assume particular module systems and project scripts—please align these snippets with the actual conventions and scripts used in the existing e2e tests so the agents don’t suggest patterns that won’t compile or run in this repo.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- There’s a lot of duplicated guidance between the generator, reviewer, orchestrator, and coverage analyzer (e.g., URLSearchParams usage, Jira bugfix format, file locations); consider extracting shared standards into a single short reference section that each agent links to so future updates don’t get out of sync.
- Some of the embedded code examples (e.g., `const fs = require('fs');`, specific `npm` commands, and relative paths) assume particular module systems and project scripts—please align these snippets with the actual conventions and scripts used in the existing e2e tests so the agents don’t suggest patterns that won’t compile or run in this repo.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Add Claude agent configurations to support automated generation, review, orchestration, and coverage analysis for Playwright-based API tests in Trustify UI.
New Features: