Skip to content
This repository was archived by the owner on Jan 9, 2023. It is now read-only.

Add 0 duration story#435

Open
mxdvl wants to merge 2 commits intomainfrom
mxdvl/duration-0-story
Open

Add 0 duration story#435
mxdvl wants to merge 2 commits intomainfrom
mxdvl/duration-0-story

Conversation

@mxdvl
Copy link
Contributor

@mxdvl mxdvl commented Jul 20, 2022

What does this change?

Add a new story for the 0 duration YoutubeAtom

How to test

Check Storybook

How can we measure success?

Visual regression.

Have we considered potential risks?

N/A

Images

image

Accessibility

@changeset-bot
Copy link

changeset-bot bot commented Jul 20, 2022

⚠️ No Changeset found

Latest commit: 48dc9a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mxdvl mxdvl requested a review from a team July 20, 2022 16:13
@github-actions
Copy link
Contributor

github-actions bot commented Jul 20, 2022

Size Change: -27 B (0%)

Total Size: 61.8 kB

Filename Size Change
dist/commonjs/YoutubeAtomOverlay.js 1.13 kB -13 B (-1%)
dist/esm/YoutubeAtomOverlay.js 1.05 kB -14 B (-1%)
ℹ️ View Unchanged
Filename Size
dist/commonjs/Answers.js 1.26 kB
dist/commonjs/AudioAtom.js 2.74 kB
dist/commonjs/ChartAtom.js 400 B
dist/commonjs/common/MaintainAspectRatio.js 422 B
dist/commonjs/expandableAtom/Body.js 979 B
dist/commonjs/expandableAtom/Container.js 769 B
dist/commonjs/expandableAtom/Footer.js 1.2 kB
dist/commonjs/expandableAtom/Summary.js 1 kB
dist/commonjs/ExplainerAtom.js 664 B
dist/commonjs/GuideAtom.js 596 B
dist/commonjs/index.js 534 B
dist/commonjs/InteractiveAtom.js 494 B
dist/commonjs/InteractiveLayoutAtom.js 443 B
dist/commonjs/KnowledgeQuiz.js 2.42 kB
dist/commonjs/lib/formatTime.js 384 B
dist/commonjs/lib/ophan.js 320 B
dist/commonjs/lib/pillarPalette.js 273 B
dist/commonjs/lib/unifyPageContent.js 694 B
dist/commonjs/lib/useIsInView.js 692 B
dist/commonjs/PersonalityQuiz.js 2.6 kB
dist/commonjs/Picture.js 1.65 kB
dist/commonjs/ProfileAtom.js 592 B
dist/commonjs/QandaAtom.js 574 B
dist/commonjs/RecipeSchemaAtom.js 295 B
dist/commonjs/SharingIcons.js 879 B
dist/commonjs/TimelineAtom.js 1.21 kB
dist/commonjs/types.js 97 B
dist/commonjs/VideoAtom.js 522 B
dist/commonjs/YoutubeAtom.js 1.31 kB
dist/commonjs/YoutubeAtomPlaceholder.js 372 B
dist/commonjs/YoutubeAtomPlayer.js 2.79 kB
dist/commonjs/YoutubeAtomSticky.js 2 kB
dist/esm/Answers.js 1.14 kB
dist/esm/AudioAtom.js 2.68 kB
dist/esm/ChartAtom.js 330 B
dist/esm/common/MaintainAspectRatio.js 361 B
dist/esm/expandableAtom/Body.js 907 B
dist/esm/expandableAtom/Container.js 706 B
dist/esm/expandableAtom/Footer.js 1.13 kB
dist/esm/expandableAtom/Summary.js 944 B
dist/esm/ExplainerAtom.js 606 B
dist/esm/GuideAtom.js 530 B
dist/esm/index.js 269 B
dist/esm/InteractiveAtom.js 433 B
dist/esm/InteractiveLayoutAtom.js 387 B
dist/esm/KnowledgeQuiz.js 2.33 kB
dist/esm/lib/formatTime.js 317 B
dist/esm/lib/ophan.js 252 B
dist/esm/lib/pillarPalette.js 224 B
dist/esm/lib/unifyPageContent.js 635 B
dist/esm/lib/useIsInView.js 554 B
dist/esm/PersonalityQuiz.js 2.48 kB
dist/esm/Picture.js 1.58 kB
dist/esm/ProfileAtom.js 528 B
dist/esm/QandaAtom.js 507 B
dist/esm/RecipeSchemaAtom.js 234 B
dist/esm/SharingIcons.js 813 B
dist/esm/TimelineAtom.js 1.14 kB
dist/esm/types.js 31 B
dist/esm/VideoAtom.js 467 B
dist/esm/YoutubeAtom.js 1.23 kB
dist/esm/YoutubeAtomPlaceholder.js 313 B
dist/esm/YoutubeAtomPlayer.js 2.58 kB
dist/esm/YoutubeAtomSticky.js 1.85 kB

compressed-size-action

<SvgPlay />
</div>
{duration !== undefined && duration > 0 && (
{duration ? (
Copy link
Contributor

@oliverlloyd oliverlloyd Jul 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to add this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it’s a refactor that I believe keeps thing clearer, but happy to drop it. Any thoughts @AshCorr, as you implemented the initial fix?

In any case it would not require a version bump as the result is identical.

@mxdvl mxdvl force-pushed the mxdvl/duration-0-story branch from 1e39aa2 to 48dc9a6 Compare July 22, 2022 14:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants