Merged
Conversation
|
Size Change: +8 B (0%) Total Size: 867 kB ℹ️ View Unchanged
|
b89aa98 to
cde4c0e
Compare
domlander
approved these changes
Jul 3, 2024
|
Seen on PROD (merged by @abeddow91 9 minutes and 52 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Removes the need to prop drill the edition to the datetime component, using the edition context instead.
Why?
Edition is now stored in context so it does not need to be drilled down through components. This also fixes a bug where the edition was being hardcoded for tag pages leading to the BST showing for all users, regardless of edition.
Screenshots