Ensure visibility of match stats and info#15198
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
github-actions
bot
removed
the
run_chromatic
alexduf
left a comment
alexduf
left a comment
There was a problem hiding this comment.
To me this looks good. I got worried when I saw hard coded teams and colour code but as far as I understand it this is only for testing purposes, correct?
| color: ${isLight(colour) | ||
| ? sourcePalette.neutral[7] | ||
| : sourcePalette.neutral[100]}; |
There was a problem hiding this comment.
oooh, that's the trick! Cool so we preserve contrast by looking at the colour code.
Yes, those are fixtures for the Storybook stories so we can show how the design looks with different team colours |
|
Seen on PROD (merged by @jamesmockett 7 minutes and 29 seconds ago) Please check your changes! |
2 participants
What does this change?
Updates match stat components and match info page to use fixed colours for figures and applies borders to elements to add contrast and aid visibility
Why?
We have no control over the team colours used as we get these directly from the PA feed, but these are applied to elements of the match stat components and need to be visible in light and dark mode
Screenshots