ENH: manually set iparm & support overwrite_b parameter#80
Open
capric98 wants to merge 3 commits intohaasad:masterfrom
Open
ENH: manually set iparm & support overwrite_b parameter#80capric98 wants to merge 3 commits intohaasad:masterfrom
overwrite_b parameter#80capric98 wants to merge 3 commits intohaasad:masterfrom
Conversation
overwrite_b parameteroverwrite_b parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manually set the iparm so that:
iparm(2)=103to use an OMP version of fill-in reduce algorithm withL=10optimizationiparm(6)=0 or 1depends on overwrite b or notiparm(35)=1to use 0-based indexing, hence no need to add 1 foriaandjaSupport
overwrite_bparameter:bgot an implicit copy in_check_b()(c_contiguous->f_contiguousorbis not contiguous), oroverwrite_b=Trueis explicitly provided by the user, however currently the ans array still need to be allocated (I change it tonp.empty_like(b)to avoid a 0-fill overhead) because PARDISO will try to overwritexwith 0 ifiparm(6)=1return np.ascontiguousarray(x)in_call_pardiso(), in case user can benefit from keepingf_contiguouswithoverwrite_b=Trueor multiplicate ccontig matrix with fcontig matrix, etc.pytest result: 1 failed, 23 passed. There is a "ValueError: scipy.sparse does not support dtype float16." I guess it is not from my changes?