fixed the typo dectected. also in the older versions, importPart could not open the file dialog#158
Open
tomerp wants to merge 2 commits intohamish2014:masterfrom
Open
fixed the typo dectected. also in the older versions, importPart could not open the file dialog#158tomerp wants to merge 2 commits intohamish2014:masterfrom
tomerp wants to merge 2 commits intohamish2014:masterfrom
Conversation
|
@hamish2014 is this PR still valid ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first fix in checkAssembly.py just fixes the typo "dectected" that comes up after you check the assembly:
So this should be an easy decision to merge it.
The second fix in "importPart.py" may no longer be relevant since i think you changed this file signifcantly. However you may evaluate it and decide.