Repository navigation
Ship color-independent 3D cubelet shading in v0.7.6 - #12
Merged
Merged
Conversation
zeekay
marked this pull request as ready for review
October 29, 2026 22:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The welcome and idle animations could look like a flat rotating cutout: the renderers differed and face lighting disappeared with NO_COLOR or undetected terminal color support. Both entry points now use one canonical 3D cubelet mesh with real clipped side faces, bevels, depth occlusion, physical gaps and fixed directional lighting. Shaded block/Braille glyphs preserve that lighting independently of color; RGB adds terminal theme contrast.
Native idle assembles each frame before updating stdout, removing the visible blank interval. Shared timing keeps the same continuous rigid Y rotation in welcome and idle modes. Typing, reduced motion, keyboard/mouse exits, terminal restoration and escape-free redirected aliases are preserved.
Pins upstream/codex to merged hanzoai/codex#3 at c98891b5bd9902a5c1ad78b5f323a9032e4f0c6b. Assigns 0.7.6 in Cargo.toml, Cargo.lock and npm/package.json. No dependency versions change.
Validation: final make build passed; 17 Hanzo library tests; 14 TUI animation tests, repeated with NO_COLOR after reviewing nine updated owned-screen snapshots at 80x24/80x40; four focused native tests compiled from the actual source modules and application dependencies. Live PTY checks passed for welcome/idle motion and typing at 80x24/80x40 with color and NO_COLOR, reduced motion, Ctrl+C and mouse exit, and terminal cleanup. The tag will publish binaries, npm packages and Homebrew through the existing release workflow; publication is verified separately.