Skip to content

Check if the output format is valid at the beginning#71

Merged
haoheliu merged 6 commits intohaoheliu:mainfrom
sezanzeb:check-output-format
Feb 17, 2025
Merged

Check if the output format is valid at the beginning#71
haoheliu merged 6 commits intohaoheliu:mainfrom
sezanzeb:check-output-format

Conversation

@sezanzeb
Copy link
Copy Markdown
Contributor

@sezanzeb sezanzeb commented May 30, 2024

Waiting for this to complete, just to realize that the output format was missing, was a bit frustrating. This checks if a file-extension is valid right at the start.

Other minor changes:

  • there was duplicate (and slightly outdated) code in bin/voicefixer
  • the shebang was changed to #!/usr/bin/env python
  • the description of the modes was added to the argparse help
  • Print time it took for the restoration
  • Make bin executable

I think it's really great that you provided a docker setup for this.

@sezanzeb
Copy link
Copy Markdown
Contributor Author

sezanzeb commented May 30, 2024

I still need to test if using an input and output folder still works, but I have to leave now. Other than that, this is finished.

@sezanzeb sezanzeb marked this pull request as ready for review May 31, 2024 09:04
@sezanzeb sezanzeb force-pushed the check-output-format branch from 3a4eb6a to d370a98 Compare May 31, 2024 10:27
@sezanzeb
Copy link
Copy Markdown
Contributor Author

@haoheliu this is ready for review

@haoheliu
Copy link
Copy Markdown
Owner

Nice thanks for your effort! I will take a look on that! @sezanzeb

@sezanzeb
Copy link
Copy Markdown
Contributor Author

small reminder

Copy link
Copy Markdown
Owner

@haoheliu haoheliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me

@haoheliu haoheliu merged commit aae2253 into haoheliu:main Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants