#62 Added crosswalk table + unit tests#65
Merged
Conversation
…nit tests in test_crosswalk.py
Contributor
|
Thanks Krithika! Much appreciated! |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Testing
I ran a test with some dummy questions and a fake similarity matrix which I created to test base functionality. I ensured that questions were not flagged as having similarities with themselves and ensured that no similarity scores below the threshold are flagged. I also wrote a test which calls match_instruments and uses its outputs as inputs into the generate_crosswalk_table function.
Test Configuration
Checklist