qemu builder and vbox builders now need to explicitly set WinRMPort for StepConnect

[DanHam]

#2576 introduced a bug that broke WinRM for Virtualbox builders since it made changes to the way WinRMPort was defined in helper/communicator/step_connect.go - see #4310. Hopefully this change aligns the Virtualbox builders to the new way of doing things.

I've tested the changes with the Virtualbox iso builder and communication over WinRM is now working again. I've also tested a Linux build to ensure the ssh communicator is still working as expected.

Note that the Virtualbox ovf builder should also be affected by the changes #2576 made. I haven't been able to perform any checks that this is actually the case as I don't have an ovf template to hand...

Closes #4310

[rickard-von-essen]

This probably effects qemu too, ping @vtolstov

[DanHam]

This probably effects qemu too

@rickard-von-essen I think you're right there! Perhaps

	if b.config.Comm.Type != "none" {
		steps = append(steps,
			&communicator.StepConnect{
				Config:    &b.config.Comm,
				Host:      commHost,
				SSHConfig: sshConfig,
				SSHPort:   commPort,
			},
		)
	}

from lines 394 - 403 of builder/qemu/builder.go should be changed in a similar way. e.g.

	if b.config.Comm.Type != "none" {
		steps = append(steps,
			&communicator.StepConnect{
				Config:    &b.config.Comm,
				Host:      commHost,
				SSHConfig: sshConfig,
				SSHPort:   commPort,
				WinRMPort: commPort,
			},
		)
	}

@rickard-von-essen @vtolstov Unfortunately, I don't have the setup to be able to test the qemu builder. However, if the qemu builder was broken by #2576 and that change actually fixes it, I would be happy to submit the change above in with this PR...

[vtolstov]

Please, wait i'm recheck qemu builder now

[vtolstov]

Yes, under qemu winrm is broken in current master.

==> qemu: Starting HTTP server on port 8723
==> qemu: Found port for communicator (SSH, WinRM, etc): 4435.
==> qemu: Looking for available port between 5900 and 6000 on 127.0.0.1
==> qemu: Starting VM, booting from CD-ROM
    qemu: The VM will be run headless, without a GUI. If you want to
    qemu: view the screen of the VM, connect via VNC without a password to
    qemu: 127.0.0.1:5912

But packer use default port

2016/12/23 22:09:15 packer: 2016/12/23 22:09:15 [INFO] Attempting WinRM connection...
2016/12/23 22:09:15 packer: 2016/12/23 22:09:15 [DEBUG] connecting to remote shell using WinRM
2016/12/23 22:09:15 packer: 2016/12/23 22:09:15 [ERROR] connection error: unknown error Post http://127.0.0.1:5985/wsman: dial tcp 127.0.0.1:5985: getsockopt: connection refused
2016/12/23 22:09:15 packer: 2016/12/23 22:09:15 [ERROR] WinRM connection err: unknown error Post http://127.0.0.1:5985/wsman: dial tcp 127.0.0.1:5985: getsockopt: connection refused

[vtolstov]

@DanHam please add fix for qemu builder

[DanHam]

@vtolstov Done. Hopefully that will fix. Please test again.

[vtolstov]

Thanks, i'm trying.

[vtolstov]

i'm check windows build and not it works fine, so lgtm

[DanHam]

OK. Good news. Thanks for providing the testing!

[rickard-von-essen]

Great work! 🎄

[DanHam]

@rickard-von-essen Thanks! Have a very Merry Christmas!!

[StefanScherer]

How about a small bugfix release 0.12.2 which fixes this problem for VirtualBox?