This repository was archived by the owner on Dec 10, 2025. It is now read-only.
fix(lib): Fixed bug where pipenv was always created, added support for poetry and uv python package managers#3925
Open
bendog wants to merge 1 commit intohashicorp:mainfrom
Open
fix(lib): Fixed bug where pipenv was always created, added support for poetry and uv python package managers#3925bendog wants to merge 1 commit intohashicorp:mainfrom
bendog wants to merge 1 commit intohashicorp:mainfrom
Conversation
…ve match for python package management
Author
|
I'm having a lot of trouble getting the tests to run, all tests are failing. |
|
@xiehan / @DanielMSchmidt / @mutahhir any of you who can help this PR? This is really annoying and seems very simple. |
Author
|
Thanks, would be great to get this fixed. |
Author
|
Any update on this please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Fixes #2321 (probably others too)
Description
Previously the CDKTF CLI was giving a false positive match for Pipenv as the packaging tool if Pipenv was installed on the system. It is incredibly common to have Pipenv installed but not in use for a Python project.
I've also added additional support for Poetry and UV package managers (which are both more popular than Pipenv).
Checklist