resourceSetRegionInStateInterceptor prevents proper resource removal detection for Framework resources

[marcinbelczewski]

Terraform and AWS Provider Version

Terraform v1.11.0
on darwin_arm64

Affected Resource(s) or Data Source(s)

All resources using Terraform Plugin Framework that have region attributes

Expected Behavior

When a resource is deleted outside of Terraform (resource disappears), the next terraform plan should detect the resource as missing and propose to recreate it with action [create].

Actual Behavior

When a resource is deleted outside of Terraform, the resource appears to still exist in state with null values instead of being properly detected as missing. This causes incorrect plan actions showing [destroy, create] instead of just [create].

Relevant Error/Panic Output

Sample Terraform Configuration

Click to expand configuration

resource "aws_s3tables_namespace" "example" {
  namespace        = "example_namespace"
  table_bucket_arn = aws_s3tables_table_bucket.example.arn
}

resource "aws_s3tables_table_bucket" "example" {
  name = "example-bucket"
}

func TestAccS3TablesTable_disappears(t *testing.T) {
	ctx := acctest.Context(t)

	var table s3tables.GetTableOutput
	bucketName := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix)
	namespace := strings.ReplaceAll(sdkacctest.RandomWithPrefix(acctest.ResourcePrefix), "-", "_")
	rName := strings.ReplaceAll(sdkacctest.RandomWithPrefix(acctest.ResourcePrefix), "-", "_")
	resourceName := "aws_s3tables_table.test"

	resource.ParallelTest(t, resource.TestCase{
		PreCheck: func() {
			acctest.PreCheck(ctx, t)
			testAccPreCheck(ctx, t)
		},
		ErrorCheck:               acctest.ErrorCheck(t, names.S3TablesServiceID),
		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories,
		CheckDestroy:             testAccCheckTableDestroy(ctx),
		Steps: []resource.TestStep{
			{
				Config: testAccTableConfig_basic(rName, namespace, bucketName),
				Check: resource.ComposeAggregateTestCheckFunc(
					testAccCheckTableExists(ctx, resourceName, &table),
					acctest.CheckFrameworkResourceDisappears(ctx, acctest.Provider, tfs3tables.NewResourceTable, resourceName),
				),
				ExpectNonEmptyPlan: true,
				// Add this recommended plan check to trigger the error
				ConfigPlanChecks: resource.ConfigPlanChecks{
					PostApplyPostRefresh: []plancheck.PlanCheck{
						plancheck.ExpectResourceAction(resourceName, plancheck.ResourceActionCreate),
					},
				},				
			},
		},
	})
}

Steps to Reproduce

1. Amend TestAccS3TablesTable_disappears acceptance test enabling the recommended plancheck.ResourceActionCreate
2. Run the test
3. Observe failed test:

=== RUN TestAccS3TablesTable_disappears
=== PAUSE TestAccS3TablesTable_disappears
=== CONT TestAccS3TablesTable_disappears
table_test.go:116: Step 1/1 error: Post-apply refresh plan check(s) failed:
'aws_s3tables_table.test' - expected Create, got action(s): [delete create]
--- FAIL: TestAccS3TablesTable_disappears (26.54s)

Debug Logging

No response

GenAI / LLM Assisted Development

• claude code
• Chat GPT o3

not super helpful tbh ;-)

Important Facts and References

No response

Would you like to implement a fix?

Yes

[github-actions]

Community Guidelines

This comment is added to every new Issue to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

• Please vote on this Issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
• Please see our prioritization guide for additional information on how the maintainers handle prioritization.
• Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Issue and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.

[github-actions]

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

[github-actions]

This functionality has been released in v6.8.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.